doc(extension): add extension and generator docs #1652
Conversation
c8d27be to
08060e1
Compare
05e9963 to
01bcb0a
Compare
|
IMHO, we should merge both files. WDYT @alexandre-daubois? |
|
It was not always easy to write some parts because important things are sometimes dispatched between both pages. So maybe this would help to have a more fluent doc. I'm having a look on how we can merge them 👍 |
01bcb0a to
c3eb5a6
Compare
|
Both docs are merged now |
docs/extensions.md
Outdated
|
|
||
| ```c | ||
| PHPAPI int register_internal_extensions(void) | ||
| { |
There was a problem hiding this comment.
I suggest using helper functions provided by FrankenPHP even for the "manual" code. WDYT?
There was a problem hiding this comment.
Suits me fine as it showcases FrankenPHP benefits even when creating manually the extension!
docs/extensions.md
Outdated
|
|
||
| We'll start with the manual approach to understand how extensions work under the hood, then show how the generator simplifies the process. | ||
|
|
||
| ## Manual Implementation |
There was a problem hiding this comment.
I would start with the easiest option (code generator), then show the advanced way.
371f178 to
2c08a7b
Compare
2c08a7b to
064d372
Compare
|
Thanks! |
|
Now that this PR is merged what is the URL to the web page? |
|
It should be released soon I guess, with the next release of FrankenPHP! |
Here are the docs for both the extensions generator and creating extensions "the old way". I'll take care of the French translation once this version is validated!
Related to #1651