feat: FrankenPHP extensions #1651
Conversation
|
this is gonna take awhile... |
| // EXPERIMENTAL: PHPString converts a Go string to a zend_string with copy. The string can be | ||
| // non-persistent (automatically freed after the request by the ZMM) or persistent. If you choose | ||
| // the second mode, it is your repsonsability to free the allocated memory. |
There was a problem hiding this comment.
Also important to note that while persistent strings can be used across requests, they should not be used across threads. To be able to use a string across multiple threads, it also needs to be 'interned' to avoid refcounting entirely like here
|
Here is the docs PR: #1652 |
|
The CI failure looks related to a change in SPC. Do you know what we're doing wrong @henderkes @crazywhalecc? It looks like we pass the |
|
Seems that making |
|
should be fixed now, we reverted to a boolean flag for some reason, the framework we used for option parsing defaults --build-embed to null, rather than true, like it does without a value to pass. |
* feat: add helpers to create PHP extensions * cs * feat: GoString * test * add test for RegisterExtension * cs * optimize includes * fix
* feat(extensions): add the PHP extension generator * unexport many types * unexport more symbols * cleanup some tests * unexport more symbols * fix * revert types files * revert * add better validation and fix templates * remove GoStringCopy * small fixes --------- Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
|
🎉 |
See: #1649 and https://github.com/dunglas/frankenphp-etcd