get package tag version from binary instead #1606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1730e07 to
d2dd016
Compare
| fi | ||
| fi | ||
| version_output="$(dist/"$bin" version)" | ||
| frankenphp_version=$(echo "$version_output" | grep -oP 'FrankenPHP\s+\K[^ ]+' || true) |
Member
There was a problem hiding this comment.
our scripts use capitalized variables. Any reason you are deviating here?
Contributor
Author
There was a problem hiding this comment.
meant to signify a non-exported variable that also isn't read from the command line. I essentially wanted to avoid people thinking the FRANKENPHP_VERSION variable would influence it. Can give it a different all uppercase name!
Contributor
Author
There was a problem hiding this comment.
(should probably change all the other variables in the script and all our other scripts then, too, because so far we seem to use lowercase names for all "private" variables)
Member
|
Thanks |
Member
|
It looks like it still doesn't work: https://github.com/dunglas/frankenphp/releases/tag/v1.7.0 |
henderkes
added a commit
to mhpcc/frankenphp
that referenced
this pull request
Jun 5, 2025
* get package tag version from binary instead * capture output for better debugging instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1605