adding database server examples#3639
Conversation
cmb69
left a comment
There was a problem hiding this comment.
Thank you for the PR! This looks generally good to me, also some issues still need to be resolved.
@kamil-tekiela, what do you think?
| <para> | ||
| The MySQL extensions support the MySQL protocol. | ||
| Examples of compatible database servers are | ||
| <link xlink:href="https://mariadb.org/">MariaDB Server</link>, |
There was a problem hiding this comment.
The URLs should better be entities for easier updating across translations; see https://github.com/php/doc-base/blob/master/entities/global.ent (that is another repo, because it is used by all translations of the PHP manual).
There was a problem hiding this comment.
Added URLs now here, will change to variables when this is merged: #3639
|
Hmm, CI is reporting "Namespace prefix xlink for href on link is not defined"; not sure why, since apparently the respective XML namespace is declared. |
kamil-tekiela
left a comment
There was a problem hiding this comment.
It looks fine to me but I wouldn't duplicate the information. Pick one spot it fits the best.
|
The build still fails, likely because of doc-en/reference/mysqlinfo/set.xml Line 4 in 227766a The XML namespace declaration should probably be added to this element. |
cmb69
left a comment
There was a problem hiding this comment.
This looks good to me now, but I think we should merge php/doc-base#144 first, and then adapt and merge this PR (might be a bit easier to handle for translators).
|
Since php/doc-base#144 has been merged, could you please update the PR to use these entities? |
|
Thank you very much! |
Adding database server examples that use the MySQL protocol (MariaDB, MySQL, Percona, TiDB) as per discussion #3628