Fix return type explanation for array_recursive#1649
Merged
cmb69 merged 1 commit intophp:masterfrom Jun 27, 2022
othercorey:fix-array-replace
Merged
Fix return type explanation for array_recursive#1649cmb69 merged 1 commit intophp:masterfrom othercorey:fix-array-replace
cmb69 merged 1 commit intophp:masterfrom
othercorey:fix-array-replace
Conversation
Member
|
I don't think this should be documented here. It is generally undefined behavior to pass values of unexpected types to an internal function. |
Contributor
Author
|
So just drop the null entirely? |
Member
|
Oh, right! |
Contributor
Author
|
Should I say previously returned null on error without explaining? I guess it was just a mess when this stuff happened before throwing errors. I'm simply updating missing docs after updating psalms function signatures. |
Member
|
No, I wouldn't even mention the |
tiffany-taylor
pushed a commit
to tiffany-taylor/doc-en
that referenced
this pull request
Jan 16, 2023
claudepache
pushed a commit
to claudepache/php-doc-en
that referenced
this pull request
Jun 1, 2023
This was referenced May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.