[PHP 8.0] Add new DOM interfaces#1025
Conversation
There was a problem hiding this comment.
I think updates to DOMElement are also necessary. For instance it should be updated so the class reflects that it now implements DOMParentNode, DOMChildNode. Going based off changes noted here php/php-src#4709, I've compiled this list of the items needing updates to class synopsis:
-
DOMElementneedsimplements DOMParentNode, DOMChildNode -
DOMDocumentneedsimplements DOMParentNode -
DOMFragmentneedsimplements DOMParentNode -
DOMCharacterDataneedsimplements DOMChildNode
All the affected items will also need to be updated so the class synopsis includes the appropriate references to the inherited methods from the respective interfaces. I'm guessing that this would be OK for them to all link back to the interfaces docs for the method.
|
@mallardduck thanks! Yep, as far as I can see, these changes implemented in #839 |
mallardduck
left a comment
There was a problem hiding this comment.
Merge along with: #839
cmb69
left a comment
There was a problem hiding this comment.
Thank you for the PR! It might make sense to add some further methods to the see also sections, e.g. DOMNode::appendChild comes to mind. I'm not quite sure about the usage of "current node"; AIUI, this refers to $this, so perhaps makes that more explicit.
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
|
Sorry for the long implementation =( @cmb69 Thanks for the review, as always =)
Added new links.
What do you think about "object context" instead of "current node"? |
Maybe, not sure. |
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Add new
DOMChildNodeandDOMParentNodeinterfaces.