Revise pushEvent / pushEventTo docs#4220
Merged
Merged
Conversation
This was referenced May 8, 2026
For the TS API docs, document each method signature independently, so that each one can focus on its particular behavior. This makes the generated API docs easier to consume and link to. For the summarized JS interop guide, mention that the callback version of those methods silently ignores errors as the key distinction between the two versions. Rephrase the `pushEventTo` guide prose to avoid discussing the `selectorOrTarget` parameter twice.
Member
|
🙌 |
SteffenDE
pushed a commit
that referenced
this pull request
May 29, 2026
For the TS API docs, document each method signature independently, so that each one can focus on its particular behavior. This makes the generated API docs easier to consume and link to. For the summarized JS interop guide, mention that the callback version of those methods silently ignores errors as the key distinction between the two versions. Rephrase the `pushEventTo` guide prose to avoid discussing the `selectorOrTarget` parameter twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the TS API docs, document each method signature independently, so that each one can focus on its particular behavior. This makes the generated API docs easier to consume and link to.
For the summarized JS interop guide, mention that the callback version of those methods silently ignores errors as the key distinction between the two versions.
Rephrase the
pushEventToguide prose to avoid discussing theselectorOrTargetparameter twice.Closes #4075.