Support attribute_formatters#3781
Merged
SteffenDE merged 5 commits intophoenixframework:mainfrom May 4, 2025
Merged
Conversation
0f9f8db to
ee38659
Compare
ee38659 to
0e6a85c
Compare
josevalim
reviewed
May 3, 2025
Member
|
This is looking great, just one comment. :) |
josevalim
reviewed
May 4, 2025
josevalim
approved these changes
May 4, 2025
SteffenDE
approved these changes
May 4, 2025
Collaborator
|
Nice! |
Collaborator
|
Thank you! 🙌🏻 |
aptinio
added a commit
to aptinio/tailwind_formatter
that referenced
this pull request
Jan 25, 2026
…tter TailwindFormatter currently vendors Phoenix.LiveView.HTMLFormatter code so that it can use the private `tokenize/1` function. However, problems arise when the vendored code and the user's Phoenix.LiveView version gets out of sync. A PR has been submitted to Phoenix.LiveView team in the hopes of having this function publicly exposed: phoenixframework/phoenix_live_view#3778 Instead, a suggestion was made to add an `:attribute_formatters` config option to Phoenix.LiveView.HTMLFormatter. This has been available since Phoenix.LiveView v1.1 phoenixframework/phoenix_live_view#3781 This PR removes the vendored code and converts TailwindFormatter from a mix formatter to an attribute formatter of Phoenix.LiveView.HTMLFormatter.
aptinio
added a commit
to aptinio/tailwind_formatter
that referenced
this pull request
Jan 25, 2026
TailwindFormatter currently vendors Phoenix.LiveView.HTMLFormatter code so that it can use the private `tokenize/1` function. However, problems arise when the vendored code and the user's LiveView version gets out of sync. A PR has been submitted to the Phoenix.LiveView team in the hopes of having this function publicly exposed: phoenixframework/phoenix_live_view#3778 Instead, a suggestion was made to add an `:attribute_formatters` config option to Phoenix.LiveView.HTMLFormatter. This has been available since Phoenix.LiveView v1.1 phoenixframework/phoenix_live_view#3781 This PR removes the vendored code and converts TailwindFormatter from a mix formatter to an attribute formatter of Phoenix.LiveView.HTMLFormatter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.