Skip to content

Tests coverage phalcon 2#16889

Merged
niden merged 55 commits into
phalcon:5.0.xfrom
niden-code:tests-coverage-phalcon-2
Apr 15, 2026
Merged

Tests coverage phalcon 2#16889
niden merged 55 commits into
phalcon:5.0.xfrom
niden-code:tests-coverage-phalcon-2

Conversation

@niden

@niden niden commented Apr 15, 2026

Copy link
Copy Markdown
Member

Thorough review of the tests, increasing test coverage and cleanup.

Changed

  • Changed Phalcon\Assets\Manager filter type check from is_object() to typeof and updated the error message to "The filter is not valid" #16889
  • Changed Phalcon\Di\Exception message for missing services from "was not found in the dependency injection container" to "is not registered in the container" #16889
  • Changed Phalcon\Di\Service\Builder error messages for service parameters to use double quotes instead of single quotes #16889
  • Changed exception messages across multiple components to use "does not" instead of "doesn't" for consistency #16889

Fixed

  • Fixed Phalcon\Filter\Validation\AbstractValidator::messageFactory() to pass the joined field string to Phalcon\Messages\Message instead of the raw array when multiple fields are provided #16889
  • Fixed Phalcon\Filter\Validation::bind() to skip the dependency injection container lookup when data is empty, preventing unnecessary Di\Exception errors #16889
  • Fixed Phalcon\Html\Escaper::css() and Phalcon\Html\Escaper::js() to return an empty string instead of false when the input is empty or contains only a null codepoint #16889
  • Fixed Phalcon\Http\Response::setStatusCode() exception message from "Non-standard statuscode given without a message" to "Non-standard status-code given without a message" #16889
  • Fixed Phalcon\Image\Adapter\Imagick::processPixelate() to explicitly cast division result to int to prevent implicit float-to-int deprecation #16889
  • Fixed Phalcon\Support\Helper\Json\Encode to prefix the InvalidArgumentException message with "json_encode error: " for consistency #16889
  • Fixed Phalcon\Storage\Adapter\Libmemcached, Phalcon\Storage\Adapter\Redis and Phalcon\Storage\Adapter\Weak to call initSerializer() during construction #16889
  • Fixed Phalcon\Storage\Adapter\Redis to initialize lifetime from options during construction #16889

@niden niden requested a review from Jeckerson April 15, 2026 16:43
@niden niden self-assigned this Apr 15, 2026
@niden niden added enhancement Enhancement to the framework bug A bug report 5.0 The issues we want to solve in the 5.0 release labels Apr 15, 2026
@niden niden added this to Phalcon v5 Apr 15, 2026
@niden niden moved this to In Progress in Phalcon v5 Apr 15, 2026
@niden niden merged commit 6f856af into phalcon:5.0.x Apr 15, 2026
61 checks passed
@niden niden deleted the tests-coverage-phalcon-2 branch April 15, 2026 18:02
@niden niden moved this from In Progress to Implemented in Phalcon v5 Apr 22, 2026
@niden niden moved this from Implemented to Released in Phalcon v5 Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0 The issues we want to solve in the 5.0 release bug A bug report enhancement Enhancement to the framework

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

2 participants