Tests coverage phalcon 2#16889
Merged
Merged
Conversation
Jeckerson
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thorough review of the tests, increasing test coverage and cleanup.
Changed
Phalcon\Assets\Managerfilter type check fromis_object()totypeofand updated the error message to"The filter is not valid"#16889Phalcon\Di\Exceptionmessage for missing services from"was not found in the dependency injection container"to"is not registered in the container"#16889Phalcon\Di\Service\Buildererror messages for service parameters to use double quotes instead of single quotes #16889"does not"instead of"doesn't"for consistency #16889Fixed
Phalcon\Filter\Validation\AbstractValidator::messageFactory()to pass the joined field string toPhalcon\Messages\Messageinstead of the raw array when multiple fields are provided #16889Phalcon\Filter\Validation::bind()to skip the dependency injection container lookup whendatais empty, preventing unnecessaryDi\Exceptionerrors #16889Phalcon\Html\Escaper::css()andPhalcon\Html\Escaper::js()to return an empty string instead offalsewhen the input is empty or contains only a null codepoint #16889Phalcon\Http\Response::setStatusCode()exception message from"Non-standard statuscode given without a message"to"Non-standard status-code given without a message"#16889Phalcon\Image\Adapter\Imagick::processPixelate()to explicitly cast division result tointto prevent implicit float-to-int deprecation #16889Phalcon\Support\Helper\Json\Encodeto prefix theInvalidArgumentExceptionmessage with"json_encode error: "for consistency #16889Phalcon\Storage\Adapter\Libmemcached,Phalcon\Storage\Adapter\RedisandPhalcon\Storage\Adapter\Weakto callinitSerializer()during construction #16889Phalcon\Storage\Adapter\Redisto initializelifetimefrom options during construction #16889