Add copy examples#2762
Merged
davecramer merged 3 commits intopgjdbc:masterfrom Feb 9, 2023
Merged
Conversation
vlsi
requested changes
Feb 9, 2023
Comment on lines
+954
to
+955
| } catch (Exception ex) { | ||
| ex.printStackTrace(); |
Member
There was a problem hiding this comment.
I guess this catch is non-essential, and we don't want to promote printStackTrace pattern :)
Suggested change
| } catch (Exception ex) { | |
| ex.printStackTrace(); |
Comment on lines
+947
to
+950
| try { | ||
| cp.cancelCopy(); | ||
| } catch (SQLException se) { // should fail with obsolete operation | ||
| se.printStackTrace(); |
Member
There was a problem hiding this comment.
Do we require calling cancelCopy? Why call it if we expect it to fail?
Member
Author
There was a problem hiding this comment.
I pulled this out of a test case. We really don't need it.
| private int dataRows = origData.length; | ||
| private String sql = "COPY copytest FROM STDIN"; | ||
| try (Connection con = DriverManager.getConnection(url, "postgres", "somepassword")){ | ||
| createTempTable(con, "copytest", "stringvalue text, intvalue int, numvalue numeric(5,2)"); |
Member
There was a problem hiding this comment.
Ideally, the sample should be copy-pasteable, so we should use plain try (Statement st = con.createStatement()) { st.execute("create table ...") }
An alternative option is to provide table DDL above Java code, so the users create or reuse an existing table.
| CopyOut cp = copyAPI.copyOut(sql); | ||
| int count = 0; | ||
| byte[] buf; | ||
| while ((buf = cp.readFromCopy()) != null) { |
Member
There was a problem hiding this comment.
It would be nice to clarify what does byte[] buf mean.
Does it contain single row only? Does it contain just a bunch of next bytes?
vlsi
reviewed
Feb 9, 2023
davecramer
added a commit
to davecramer/pgjdbc
that referenced
this pull request
Feb 14, 2023
* Add copy examples
davecramer
added a commit
that referenced
this pull request
Feb 15, 2023
* fix: fix testGetSQLTypeQueryCache by searching for xid type. We used to search for box type but it is now cached fix OidValueCorrectnessTest BOX_ARRAY OID, by adding BOX_ARRAY to the oidTypeName map * branches: '*' to branches: '**' in the workflow definition to ensure that all pull requests get tested * added alias /about/license.html (#2765) * Add copy examples (#2762) * make changelogs more compact, only show the link to the changelog (#2758) add SNAPSHOT link to download page * Update README.md (#2759) * re-add slonik duke image (#2760) * edit changelogs to make them correct and readable (#2743) * Correct the instructions for building without tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.