WhoAllocated<T> doesn't need to be generic over any T#901
Merged
Conversation
…anges it to just `WhoAllocated`.
…` and add some doccomments.
workingjubilee
approved these changes
Nov 30, 2022
Merged
yrashk
pushed a commit
to yrashk/pgx
that referenced
this pull request
Dec 6, 2022
…oundation#901) * `WhoAllocated<T>` doesn't need to be generic over any `T`, so this changes it to just `WhoAllocated`. * rename the `WhoAllocated::free` function to `WhoAllocated::maybe_free` and add some doccomments.
usamoi
pushed a commit
to tensorchord/pgrx
that referenced
this pull request
Mar 6, 2025
…oundation#901) * `WhoAllocated<T>` doesn't need to be generic over any `T`, so this changes it to just `WhoAllocated`. * rename the `WhoAllocated::free` function to `WhoAllocated::maybe_free` and add some doccomments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... so this changes it to just
WhoAllocated.I wanted to put it up now as I'm going to be working on some stuff that this will make better.