C enums as module consts + deprecation#1748
Merged
workingjubilee merged 7 commits intoJul 5, 2024
Merged
Conversation
aa21e3b to
37467f8
Compare
Contributor
|
This is cool. Has this ModuleConsts form always been there or is it relatively new to bindgen? Neat |
Member
Author
|
It's been there since before pgrx's initial commit. |
workingjubilee
commented
Jul 5, 2024
workingjubilee
commented
Jul 5, 2024
Comment on lines
+63
to
+70
| XACT_EVENT_ABORT => PgXactCallbackEvent::Abort, | ||
| XACT_EVENT_COMMIT => PgXactCallbackEvent::Commit, | ||
| XACT_EVENT_PARALLEL_ABORT => PgXactCallbackEvent::ParallelAbort, | ||
| XACT_EVENT_PARALLEL_COMMIT => PgXactCallbackEvent::ParallelCommit, | ||
| XACT_EVENT_PARALLEL_PRE_COMMIT => PgXactCallbackEvent::ParallelPreCommit, | ||
| XACT_EVENT_PREPARE => PgXactCallbackEvent::Prepare, | ||
| XACT_EVENT_PRE_COMMIT => PgXactCallbackEvent::PreCommit, | ||
| XACT_EVENT_PRE_PREPARE => PgXactCallbackEvent::PrePrepare, |
Member
Author
There was a problem hiding this comment.
Making these matches a bit less awful to read was basically my primary goal here.
workingjubilee
commented
Jul 5, 2024
usamoi
pushed a commit
to tensorchord/pgrx
that referenced
this pull request
Mar 6, 2025
I tried to do without the deprecation warning code but I found it simply so annoying that rustc couldn't find the right names (its Levenshtein-derived algorithm doesn't reason about pathnames quite that way) that I figured it would be easiest to simply add the relevant codegen. That made it possible to distinguish between disappearing types and now-outdated names. Closes pgcentralfoundation#1370.
workingjubilee
added a commit
to workingjubilee/pgrx
that referenced
this pull request
Oct 28, 2025
This was added as a mercy in pgcentralfoundation#1748 to help migration but time is up: It has been over a year now.
workingjubilee
added a commit
that referenced
this pull request
Oct 28, 2025
This was added as a mercy in #1748 to help migration but time is up: It has been over a year now.
daamien
pushed a commit
to daamien/pgrx
that referenced
this pull request
Dec 15, 2025
This was added as a mercy in pgcentralfoundation#1748 to help migration but time is up: It has been over a year now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to do without the deprecation warning code but I found it simply so annoying that rustc couldn't find the right names (its Levenshtein-derived algorithm doesn't reason about pathnames quite that way) that I figured it would be easiest to simply add the relevant codegen. That made it possible to distinguish between disappearing types and now-outdated names.
Closes #1370.