Deprecate variadic! support#1713
Conversation
| }; | ||
| } | ||
|
|
||
| #[deprecated(since = "0.12.0", note = "try VariadicArray")] |
There was a problem hiding this comment.
Just delete the macro. There's enough breaking changes in develop that one more doesn't matter.
There was a problem hiding this comment.
All the real parts of the macro, and thus the things that complicate its support internally, are gone. There are other users that don't have their code published, and for them, telling them what else to do may make migration slightly easier.
There was a problem hiding this comment.
Obviously I've broken probably a fair number of unpublished extensions with this version but it seems low-effort.
There was a problem hiding this comment.
can it become a compile error instead of a deprecated warning? Cuz using it now would mean it doesn't dooooooooo what they want, right?
There was a problem hiding this comment.
actually it already is lol
This removes `variadic!` support. The macro itself remains, but it does nothing now, and has a deprecation note. There are no uses of it in this codebase, the ZomboDB codebase, or other pgrx-using codebases I have seen. `VariadicArray` completely surpasses it in utility. I want to remove, ideally, all these ad-hoc type macros, but they may need to be replaced in functionality. This one, however, is already dead.
Closes out the promise of pgcentralfoundation#1713
This removes
variadic!support. The macro itself remains, but it does nothing now, and has a deprecation note. There are no uses of it in this codebase, the ZomboDB codebase, or other pgrx-using codebases I have seen.VariadicArraycompletely surpasses it in utility. I want to remove, ideally, all these ad-hoc type macros, but they may need to be replaced in functionality. This one, however, is already dead.