Fix OpenVPN services actions#635
Closed
AlexTrushkovsky wants to merge 2 commits intopfrest:masterfrom
Closed
Conversation
Member
|
Thanks for the PR. This entire endpoint is currently being reworked for v2.4.0 to accommodate this particular issue as well as related issues like #634. Adding fields that are specific to individual services can become messy and cause unnecessary confusion for users who may not use those services; especially considering the API already has access to the extra parameters needed for each individual service. The new approach will lookup and perform the action on the exact service by an ID instead of the name, so users don't need to worry about explicitly providing extra parameters. This will better match the functionality in the webConfigurator as well. Thanks again for your effort and willingness to contribute! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since openvpn services share a common name, the name alone is not enough to perform any action with a particular service. For this purpose, pfsense has $extras to pass vpnid and vpnmode. They are needed to find a specific service process.
Example: https://github.com/pfsense/pfsense/blob/RELENG_2_7_2/src/etc/inc/service-utils.inc#L851