fix: Infinite subgraph_isomorphisms_iter for empty isomorphisms
#780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly added test fails with the old code, since initial state is always complete and hence the iterator's return value will always be
Some(_).I fixed this by making
GraphMatcherthe only entrypoint toisomorphisms, and moving that edge case logic into itsIteratorimplementation. This is a bit awkward, but I am unsure how to adaptisomorphismsitself, since it currently assumes having at least one mapped node pair before returning a result.Benchmark comparisons for the changed code:
Details
Command: `cargo +nightly bench --bench iso`
Old:
New: