fix: Bring back VisitMap impl for std HashSet
#764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisitMap impl for std HashSetVisitMap impl for std HashSet
1 task
bushrat011899
approved these changes
Apr 7, 2025
Contributor
bushrat011899
left a comment
There was a problem hiding this comment.
This is a good fix, but I'm not sure why this is considered a semver break.
| } | ||
|
|
||
| #[cfg(feature = "std")] | ||
| impl<N, S> VisitMap<N> for std::collections::HashSet<N, S> |
Contributor
There was a problem hiding this comment.
I don't really understand how this is considered a semver break, but I guess it is?
Collaborator
Author
There was a problem hiding this comment.
This is most likely due to the cargo-semver-checks bug obi1kenobi/cargo-semver-checks#1200
Member
There was a problem hiding this comment.
Fixed now with #765.
For reference to the links pointing here, here's the error we had:
--- failure trait_newly_sealed: pub trait became sealed ---
Description:
A publicly-visible trait became sealed, so downstream crates are no longer able to implement it
ref: https://rust-lang.github.io/api-guidelines/future-proofing.html#sealed-traits-protect-against-downstream-implementations-c-sealed
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/trait_newly_sealed.ron
Failed in:
trait petgraph::data::Create in file /home/runner/work/petgraph/petgraph/PR_BRANCH/src/data.rs:76
trait petgraph::data::FromElements in file /home/runner/work/petgraph/petgraph/PR_BRANCH/src/data.rs:281
trait petgraph::data::Build in file /home/runner/work/petgraph/petgraph/PR_BRANCH/src/data.rs:[53](https://github.com/petgraph/petgraph/actions/runs/14302765504/job/40080013218?pr=764#step:9:54)
https://github.com/petgraph/petgraph/actions/runs/14302765504/job/40080013218#step:9:52
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
Disables a failing semver-checks that's causing [false positives](#764 (comment)). This seems to be caused by obi1kenobi/cargo-semver-checks#1200
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
## 🤖 New release * `petgraph`: 0.8.0 -> 0.8.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.8.1](https://github.com/petgraph/petgraph/compare/petgraph@v0.8.0...petgraph@v0.8.1) - 2025-04-07 ### Bug Fixes - Bring back `VisitMap` impl for std `HashSet` ([#764](#764)) ### New Features - Add `UnionFind` capacity management methods ([#736](#736)) - add `#[track_caller]` to functions that panic ([#748](#748)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Agustín Borgna <agustinborgna@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #763 .