Skip to content

Conversation

@starovoid
Copy link
Collaborator

Two algorithms are implemented: for finding bridges and for finding points of articulation are implemented, each of which expects the argument to be a simple undirected graph. The algorithms are tested with all types of graphs.

Two algorithms are implemented, each of which expects the argument to be a simple undirected graph. In addition to quickcheck, tests have also been written to verify the correctness of the algorithm with all types of graphs.
@starovoid starovoid closed this Oct 29, 2022
@ecashin
Copy link

ecashin commented May 30, 2023

Hi. Why was the pull request closed? I don't see any conversation about it.

pragmaticTNT added a commit to pragmaticTNT/petgraph that referenced this pull request Oct 7, 2023
milkcask pushed a commit to milkcask/petgraph that referenced this pull request Sep 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2025
Derived from #473 (written by @starovoid).

Here's a list of changes that we (@gmorenz and myself) made:
- Used iteration instead of recursion; with the original version we hit
a stack overflow.
- Tried to make variable names self documenting (e.g. `fup` to
`earliest-backedge`)
- Change the output type from `Vec<G::NodeId, G::NodeId)>` to `impl
Iterator<Item = G::EdgeRef>`

The original code also had an algorithm to find articulation points
(node variant of bridge edges). To keep the pull request small we only
added the bridge algorithm. We would be happy to include the other
algorithm in another pull request. As a result we named the module
`bridges` instead of `bridges_and_ap`, we think this is probably a
better (more succinct) name anyways.

---------

Co-authored-by: xylqn7 <xylqn7@morel.SafeAI-Guest.local>
Co-authored-by: xylqn7 <xylqn7@morel.lan>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants