Fix compilation for rust nightly#154
Merged
bluss merged 1 commit intopetgraph:masterfrom Jun 16, 2017
daboross:fix-2017-06-14-nightly
Merged
Fix compilation for rust nightly#154bluss merged 1 commit intopetgraph:masterfrom daboross:fix-2017-06-14-nightly
bluss merged 1 commit intopetgraph:masterfrom
daboross:fix-2017-06-14-nightly
Conversation
Fixes by removing ambiguity between Ord::max and IndexType::max in two locations.
|
(This also affects some older branches, fyi.) |
This was referenced Jun 15, 2017
Contributor
Author
|
True, thanks for mentioning that. I guess I'll submit another PR towards |
Member
|
Thank you |
Member
|
Fixed in 0.4.5 |
bluss
pushed a commit
that referenced
this pull request
Jul 27, 2017
Fixes by removing ambiguity between Ord::max and IndexType::max in two locations.
illicitonion
added a commit
to illicitonion/pants
that referenced
this pull request
Sep 1, 2017
rust-lang/rust#42496 means that 0.4.4 no longer compiles with the most recently released rust toolchain. This was fixed in petgraph/petgraph#154 which is in 0.4.5.
khuey
pushed a commit
to khuey/petgraph
that referenced
this pull request
Feb 26, 2018
Fixes by removing ambiguity between Ord::max and IndexType::max in two locations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very small change to remove ambiguity between Ord::max and IndexType::max in two locations.
I don't directly use this library, only as an indirect dependency, but I hope this is helpful.
Fixes #153.