Skip to content

Conversation

@ABorgna
Copy link
Member

@ABorgna ABorgna commented Mar 24, 2025

Removes the TODO as mentioned in #728

BREAKING CHANGE: Marked dot::Enum as non_exhaustive

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

This PR contains breaking changes to the public Rust API.

cargo-semver-checks summary

--- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] ---

Description:
A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/enum_marked_non_exhaustive.ron

Failed in:
enum Config in /home/runner/work/petgraph/petgraph/PR_BRANCH/src/dot.rs:118

@ABorgna ABorgna changed the title feat: Make dot::Config non_exhaustive feat!: Make dot::Config non_exhaustive Mar 24, 2025
@ABorgna ABorgna added this pull request to the merge queue Mar 24, 2025
Merged via the queue into master with commit d06f6f0 Mar 24, 2025
12 of 14 checks passed
@ABorgna ABorgna deleted the ab/dot-config-exhaustive branch March 24, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants