[pull] master from pytorch:master#41
Merged
pull[bot] merged 2 commits intopeterjc123:masterfrom Sep 27, 2019
Merged
Conversation
Summary: ONNX does not support dictionaries for inputs and output. The reason is that the arg flattening and unflattening does not handle Dictionary types. This PR adds flattening/unflattening support for dictionaries and strings. However this feature should be handled with caution for input dictionaries; and users need to verify their dict inputs carefully, and keep in mind that dynamic lookups are not available. This PR will allow exporting cases where models have dictionnary outputs (detection and segmentation models in torchvision), and where dictionary inputs are used for model configurations (MultiScaleRoiAlign in torchvision). Pull Request resolved: #25889 Reviewed By: hl475 Differential Revision: D17613605 Pulled By: houseroad fbshipit-source-id: c62da4f35e5dc2aa23a85dfd5e2e11f63e9174db
Summary: Adding symbolic for baddbmm export Pull Request resolved: #26901 Reviewed By: hl475 Differential Revision: D17620967 Pulled By: houseroad fbshipit-source-id: 3931dff5a4afdcb4a45d967fb0efaf84029c16e5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )