Merged
Conversation
test: support yml or yaml chore: lint
Contributor
Author
|
@peter-evans any feedback? |
Owner
|
@patrickleet Thanks for contributing. Looked at it briefly and looks good to me. Good idea! Just trying to think about all the auth implications of this, but I think it's fine because the token used should already have access to the repository in order to create the dispatch. 🤔 I'm planning to get to this soon because I'll be making a new major version to support Node 24, anyway. |
Contributor
Author
|
I made a versioning tool / workflow - just wrote a blog post about it recently: https://hackernoon.com/releasing-new-versions-should-be-boring-really-boring Happy to make a PR to set up more automatic semantic versioning, separately, if that's something you'd be interested in |
peter-evans
added a commit
that referenced
this pull request
Nov 24, 2025
* feat: support yml or yaml (#427) test: support yml or yaml chore: lint * Fix getting permissions for the contributors who are a part of the team (#424) * Fix getActorPermission to handle team-based permissions * Use 'user.permissions' object to return permission * Add RepoPermission type * Make new build * feat: update runtime to node 24 * fix: eslint-plugin dep * fix: remove unused type * docs: update whats new --------- Co-authored-by: Patrick Lee Scott <pat@patscott.io> Co-authored-by: Volodymyr Zotov <23267003+volodymyrZotov@users.noreply.github.com>
Owner
|
Thank you! Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for workflows in yaml or yml by checking which exists by name in
getWorkflowrather than just setting it to yml.Here's an example of it working on my fork: patrickleet#1