Conversation
Robdel12
commented
Jul 16, 2019
Still fighting TS though
I'd rather make something `any` than cast everything to a type that's incorrect but makes TS happy.
timhaines
approved these changes
Jul 22, 2019
Contributor
timhaines
left a comment
There was a problem hiding this comment.
👍 Approving as all code makes sense when reading through. Trust you've exercised appropriately to consider it reliable.
Robdel12
commented
Jul 22, 2019
| const inputId = elem.getAttribute('data-percy-element-id') | ||
| const selector = `[data-percy-element-id="${inputId}"]` | ||
| const cloneEl = clonedDOM.querySelector(selector) as HTMLInputElement | ||
| const cloneEl = clonedDOM.querySelector(selector) as any |
Contributor
Author
There was a problem hiding this comment.
I called it out in the commit that made this change, but want to be clear here too.
I made this any since we're looping over an array of DOM nodes that can be any of these (at this time): select, input, textarea
Since TS doesn't allow you to recast a type, I'd rather make this any since the type of node can/will change with each loop.
djones
pushed a commit
that referenced
this pull request
Jul 22, 2019
# [0.9.0](v0.8.3...v0.9.0) (2019-07-22) ### Features * Serialize select elements values ([#295](#295)) ([3df435b](3df435b))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This will capture the selected values from
<select>elements.TODOs:
scopedimport fromdom.test.tsfile