Skip to content

✨ Add static snapshot overrides option#418

Merged
wwilsman merged 1 commit intomasterfrom
ww/static-snapshot-overrides
Jul 15, 2021
Merged

✨ Add static snapshot overrides option#418
wwilsman merged 1 commit intomasterfrom
ww/static-snapshot-overrides

Conversation

@wwilsman
Copy link
Copy Markdown
Contributor

@wwilsman wwilsman commented Jul 15, 2021

What is this?

This allows static snapshots to be configured with per-snapshot options!

static:
  files: **/*.{html,htm}
  overrides:
  - files: /foo-bar.html
    waitForSelector: .is-ready
    execute: |
      document.querySelector('.button').click()

I'm not too thrilled with the overrides name; could be options, snapshotOptions, etc?

@wwilsman wwilsman added the ✨ enhancement New feature or request label Jul 15, 2021
@wwilsman wwilsman requested a review from Robdel12 July 15, 2021 18:03
Robdel12
Robdel12 approved these changes Jul 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Robdel12 Robdel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

We have follow ups to update the readme docs right?

@wwilsman
Copy link
Copy Markdown
Contributor Author

wwilsman commented Jul 15, 2021

If we're okay with the name or one of the alternatives, we could also allow some options under the static keyword itself such as waitForTimeout, execute, etc

@wwilsman
Copy link
Copy Markdown
Contributor Author

wwilsman commented Jul 15, 2021

Upon slack discussion, we're gonna leave this PR as is. The name is okay and we can always circle back for more options.

@wwilsman wwilsman enabled auto-merge (squash) July 15, 2021 18:09
@wwilsman wwilsman merged commit 732c76d into master Jul 15, 2021
@wwilsman wwilsman deleted the ww/static-snapshot-overrides branch July 15, 2021 18:11
samarsault pushed a commit that referenced this pull request Mar 3, 2023
@dependabot
⬆️ Bump ansi-regex from 5.0.0 to 5.0.1 (#418)
6a7caa2 
Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](chalk/ansi-regex@v5.0.0...v5.0.1)

---
updated-dependencies:
- dependency-name: ansi-regex
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Robdel12 Robdel12 Robdel12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

✨ enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wwilsman @Robdel12