Skip to content

🥅 Check version of Node, exit if not supported#398

Merged
Robdel12 merged 2 commits intomasterfrom
rd/check-node-version
Jun 28, 2021
Merged

🥅 Check version of Node, exit if not supported#398
Robdel12 merged 2 commits intomasterfrom
rd/check-node-version

Conversation

@Robdel12
Copy link
Copy Markdown
Contributor

What is this?

Even though NPM/yarn checks on install, due to the number of warnings/errors in a given JS project, it's never noticed. We're going to hard error and exit on any unsupported versions of Node now to prevent support requests based on this.

@Robdel12 Robdel12 requested a review from wwilsman June 28, 2021 17:48
@Robdel12 Robdel12 force-pushed the rd/check-node-version branch from c858b9e to f79232e Compare June 28, 2021 17:49
Even though NPM/yarn checks on install, due to the number of warnings/erros in a
given JS project, it's never noticed. We're going to hard error and exit on any
unsupported versions of Node now to prevent support requests based on this.
@Robdel12 Robdel12 force-pushed the rd/check-node-version branch from f79232e to a246c35 Compare June 28, 2021 17:52
Copy link
Copy Markdown
Contributor

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits

@Robdel12 Robdel12 requested a review from wwilsman June 28, 2021 18:13
Copy link
Copy Markdown
Contributor

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎮

@Robdel12 Robdel12 added the ✨ enhancement New feature or request label Jun 28, 2021
@Robdel12 Robdel12 merged commit a8e9523 into master Jun 28, 2021
@Robdel12 Robdel12 deleted the rd/check-node-version branch June 28, 2021 18:21
samarsault pushed a commit that referenced this pull request Mar 3, 2023
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.23.4 to 2.24.0.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.23.4...v2.24.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants