Skip to content

Add off method#60

Merged
peduarte merged 1 commit into
peduarte:masterfrom
jamesfzhang:master
Feb 15, 2016
Merged

Add off method#60
peduarte merged 1 commit into
peduarte:masterfrom
jamesfzhang:master

Conversation

@jamesfzhang

@jamesfzhang jamesfzhang commented Feb 10, 2016

Copy link
Copy Markdown
Contributor

What do you think? @peduarte See #59 for details. Thanks!

@peduarte

peduarte commented Feb 11, 2016

Copy link
Copy Markdown
Owner

Hey @jamesfzhang i'm definitely opened to this. I'll do some tests to make sure it's working and then merge.

Thanks!

@jamesfzhang

jamesfzhang commented Feb 11, 2016

Copy link
Copy Markdown
Contributor Author

@peduarte Fantastic. I've been using this locally for testing and it works fine. Thanks!

peduarte
peduarte reviewed Feb 11, 2016
View reviewed changes
Comment thread js/Wallop.js Outdated
@@ -154,9 +154,11 @@

// Method so it is nicer for the user to use custom events

@peduarte peduarte Feb 11, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace this comment with:
Method to bind custom event

@jamesfzhang jamesfzhang Feb 11, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@jamesfzhang

jamesfzhang commented Feb 11, 2016

Copy link
Copy Markdown
Contributor Author

Just updated the commit with comments.

@peduarte

peduarte commented Feb 11, 2016

Copy link
Copy Markdown
Owner

Nice one, thank you

@peduarte

peduarte commented Feb 12, 2016

Copy link
Copy Markdown
Owner

@jamesfzhang Hey,
I did some tests, and in this scenario, the off method does not seem to work.
http://codepen.io/peduarte/pen/bEzVpb?editors=1111
Scroll down to the end of the code in the JS Panel and you'll see what it is.

@jamesfzhang

jamesfzhang commented Feb 12, 2016

Copy link
Copy Markdown
Contributor Author

@peduarte You need to use a named function (as opposed to an anonymous function) like so:

http://codepen.io/anon/pen/adXJVx?editors=1111

@peduarte

peduarte commented Feb 15, 2016

Copy link
Copy Markdown
Owner

Ok, that's good. I'm happy with it!
Can you also update the docs to include the off method there? Then it's good to merge 👍

@jamesfzhang

jamesfzhang commented Feb 15, 2016

Copy link
Copy Markdown
Contributor Author

@peduarte Just updated the readme. Thanks!

@peduarte

peduarte commented Feb 15, 2016

Copy link
Copy Markdown
Owner

👍

peduarte pushed a commit that referenced this pull request Feb 15, 2016
Merge pull request #60 from jamesfzhang/master
5312a7c 
Add off method
@peduarte peduarte merged commit 5312a7c into peduarte:master Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamesfzhang @peduarte