Have the option to have the slider behave like a (one-way)-carousel#1
Merged
Conversation
- Added option „wSCarousel“ - updatePagination doesn’t remove the next-button on last-item if wSCarousel === true - goTo goes to first slide if triggered on last-slide - CSS-animations work along and give a nice visual feedback
Owner
|
Thanks for this! Sorry for the delay! Been on holiday... |
Contributor
Author
|
Don't know if it should work in both directions though, but the basic implementation is quite simple and really useful imho. |
peduarte
pushed a commit
that referenced
this pull request
Feb 13, 2014
Have the option to have the slider behave like a (one-way)-carousel
Contributor
|
I think that a carousel should definitely work in both directions. Hence, if the previous button is clicked on the first slide, it should go to the last slide. @peduarte what do you think? |
Owner
|
Good point... Hmmm, I don't know, it's up to what most people think really. You guys are the ones using it! So I can do whatever you want! I'll add this to my list! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wSCarousel === true