Merged
Conversation
Add wac tests
deny access without jwt remove errorlog spam
added checks for paths given in 'default' or 'accessTo' grants updated functions to find the correct .acl file removed error_log calls from dpop validation
Potherca
approved these changes
Dec 16, 2020
for PUT on an existing file, check if the new file starts with the old file. if so, Append is enough;
…rants on a resource as well as the parent directory; this commit lets all the .acl checks in the test suite pass except for the WAC headers;
- fixed ACL path resolving - added public grants to the user grants - added WAC-Allow header in the result - added access for public users
Potherca
approved these changes
Dec 17, 2020
Potherca
approved these changes
Dec 17, 2020
…dated back to dev-tested when things are passing
Potherca
approved these changes
Dec 18, 2020
Potherca
approved these changes
Dec 20, 2020
Merge pull request #33 from pdsinterop/add-wac-tests
Potherca
approved these changes
Dec 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding dpop validation and get the webID from the jwt token so we have an id to validate acls against