Merged
Conversation
added login page small tweaks to make it in line with testsuite, passing all tests now though some are a bit faked
Potherca
approved these changes
Oct 1, 2020
Member
Potherca
left a comment
There was a problem hiding this comment.
So far things look good. Some minor comments, mostly for future reference. No need for changes.
| public function __invoke(ServerRequestInterface $request, array $args) : ResponseInterface | ||
| { | ||
| $clientId = $args['clientId']; | ||
| $returnUrl = $_POST['returnUrl']; |
Member
There was a problem hiding this comment.
For future reference: POST parameters can be retrieved from a PSR7 Request through $request->getParsedBody()
accept 'cookie' userid for the test suite for now
…set the username/password
added (non functional) token controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.