Mention the obj property which can be assigned additional properties#336
Closed
silverbucket wants to merge 2 commits intopdoc3:masterfrom
silverbucket:doc-mention-adding-props
Closed
Mention the obj property which can be assigned additional properties#336silverbucket wants to merge 2 commits intopdoc3:masterfrom silverbucket:doc-mention-adding-props
silverbucket wants to merge 2 commits intopdoc3:masterfrom
silverbucket:doc-mention-adding-props
Conversation
456869b to
94d26e8
Compare
Author
|
@kernc can we merge this? |
Member
|
@silverbucket Apologies for the long turnaround. I follow the saying, when in doubt, defer. 😅 I understand you found this workaround when you weren't able to assign new attributes to pdoc documentation objects directly due to our use of Line 520 in 65342ae In that case, with Python becoming leaner in the recent years, I'm questioning the (ancient) use of __slots__ and would probably prefer to simply remove the line ...
|
kernc
added a commit
that referenced
this pull request
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #335