Add basic auth credentials back into URL.#6
Merged
pdclark merged 1 commit intopdclark:masterfrom Nov 4, 2015
Merged
Conversation
Closed
pdclark
added a commit
that referenced
this pull request
Nov 4, 2015
Add basic auth credentials back into URL when connecting via IP address. Props @Dreamsorcerer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes basic auth not working with the plugin. This is because the plugin stripped out the auth details while getting the IP address. This adds the auth details back into the final URL.