Conversation
pbrisbin
left a comment
There was a problem hiding this comment.
I'm good with this as an incremental improvement. I left a few comments about the TODOs.
71531b2 to
4cd202f
Compare
|
I added one test and modified the build test, such that the |
|
Hey, I will address the comments and fix them in this PR, probably today :-) |
4cd202f to
7f00f12
Compare
|
Thanks! |
|
Thank you again for merging. One little question, when (or which features other) do you plan for the next release? Can I help with something? |
Releasing isn't a big deal, so I'm happy to do it whenever. Basically any time a PR lands that fixes a bug or adds a feature, I'll release shortly after. I probably won't release for this PR alone, since it's not user-facing. Pushing along other open PRs or triaging and/or addressing open Issues would be my first preference for helping out. After that, I'm happy to review and hopefully release whatever you're interested in doing! |
I see. Yes I was not asking because of this PR, but the other one (#70) with the gawk issue. Since I currently have It is somewhat harder to quickly scan the output. |
|
Oh sorry. I don't need convincing, I *meant* to release that right away.
Will do today.
…On Wed, Sep 11, 2019, 03:16 Max ***@***.***> wrote:
Releasing isn't a big deal, so I'm happy to do it whenever. Basically any
time a PR lands that fixes a bug or adds a feature, I'll release shortly
after. I probably won't release for this PR alone, since it's not
user-facing.
I see. Yes I was not asking because of this PR, but the other one (#70
<#70>) with the gawk issue. Since
I currently have aurget not patched on one system, and notice it there
every day :-)
It might probably be good, to release an update for this problem, see e.g.
the following output:
$ aurget -Syu
:: Starting AUR upgrade...
awk: cmd:4: Warning: regexp escape sequence `\"' is not a known regexp operator
:: Searching AUR...
awk: cmd:4: Warning: regexp escape sequence `\"' is not a known regexp operator
Targets (3): adminer-4.7.3-1 intellij-idea-ultimate-edition-2019.2.2-1 intellij-idea-ultimate-edition-jre-2019.2.2-1
It is somewhat harder to quickly scan the output.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#76?email_source=notifications&email_token=AAAMM7A4BBHDVIHFTLYJYATQJCLN7A5CNFSM4IUC7WN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6NQV4I#issuecomment-530254577>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAMM7CJMMNNL5UXWG3EBD3QJCLN7ANCNFSM4IUC7WNQ>
.
|
So I worked a bit through the output of
shellcheck. If you see anything problematic, or something you would like to solve in a different way, let me know.The following two things are still open (I also wrote a short note in the code):
https://www.shellcheck.net/wiki/SC2076
https://www.shellcheck.net/wiki/SC2086
The
$makepkg_optionsI would create as array and just add all the options.About the other issue I am not really sure why this was done like that. I will look into that tomorrow.