fix(ui): hide entire tabs field when admin.condition is false#16799
Merged
Conversation
Tabs field with `admin.condition` only hid child fields — tab buttons and description remained visible. Tabs branch in `addFieldStatePromise` never wrote `state[path]` for the container, so `WatchCondition` saw `passesCondition === undefined` and rendered the tabs UI regardless. Mirror row/collapsible pattern: write `state[path]` with `disableFormData` and `passesCondition: false` when the condition fails. Fixes #12761
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
Tabs branch now writes `state[path]` with `disableFormData: true` (mirrors row/collapsible). Presentational containers bypass `stripUnselectedFields`, so they appear in select-filtered state. Adjust expectation accordingly.
GermanJablo
approved these changes
Jun 1, 2026
jacobsfletch
added a commit
that referenced
this pull request
Jun 1, 2026
Identical to #16799, back-ported for 3.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12761.
Tabs field with
admin.conditiononly hides child fields — the tabs themselves and their descriptions remain visible.The entirety of the tabs field should become hidden when its condition evaluates to false.
The problem is that the tabs branch in
addFieldStatePromisenever wrotestate[path]for the container, sopassesConditionevaluates toundefined– ultimately rendering the tabs field. This fix mirrors the handling of rows and collapsibles.Before:
Screen.Recording.2026-05-29.at.4.42.01.PM.mp4
After:
Screen.Recording.2026-05-29.at.4.41.01.PM.mp4