fix: add type declarations for css export (TypeScript 6 compat)#16348
Merged
denolfe merged 1 commit intoJun 1, 2026
Merged
Conversation
Contributor
Author
|
After the build of the reproduction repo with manual patching the production run |
denolfe
added a commit
that referenced
this pull request
Jun 4, 2026
…#16867) # Overview Add TypeScript type declarations for the `./css` package export in `@payloadcms/next`, porting [#16348](#16348) from the `3.x` branch. TypeScript 6 enables [`noUncheckedSideEffectImports`](https://www.typescriptlang.org/tsconfig/noUncheckedSideEffectImports.html) by default. This makes `import '@payloadcms/next/css'` (present in all of our examples/templates) fail with: ``` error TS2882: Cannot find module or type declarations for side-effect import of '@payloadcms/next/css'. ``` The published `./css` export had no `types` field, so the side-effect import had nothing to resolve against. ## Key Changes - **Add `src/exports/css.ts`** - A regular TypeScript source file, consistent with the other exports, so the existing build pipeline emits `dist/exports/css.d.ts`. - **Wire `types` into the `./css` export** - Added the `types` condition to both the dev and `publishConfig` export maps in `packages/next/package.json`, pointing at the source declaration in dev and the built `.d.ts` when published.
Contributor
|
🚀 This is included in version v3.85.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add TypeScript type declarations for the
./csspackage export in@payloadcms/next.Why?
TypeScript 6 enables
noUncheckedSideEffectImportsby default. This causesimport '@payloadcms/next/css'— present in all three files generated bycreate-payload-app— to fail with:error TS2882: Cannot find module or type declarations for side-effect import of '@payloadcms/next/css'.
The published
./cssexport currently has notypesfield:How?
Add src/exports/css.ts as a regular TypeScript source file (consistent with all other exports so the existing build pipeline produces dist/exports/css.d.ts. Then wire the types field into both dev and publishConfig exports.
Testing:
Tested locally by copying the new files
cp ../../payload/packages/next/dist/exports/css.* node_modules/@payloadcms/next/dist/exportsand pacthing the package.json manually:
after that my test project builds fine with typescript 6.0.3
Fixes #16346