fix(storage-gcs): correctly handle alwaysInsertFields#15541
Open
r1tsuu wants to merge 1 commit into
Open
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
DanRibbens
approved these changes
Mar 19, 2026
DanRibbens
left a comment
Contributor
There was a problem hiding this comment.
Approving for now, but can we add test coverage to this for any future regressions and ensure all adapters behave the same?
Member
Author
|
Yes, I'll add before merging. |
Member
Author
|
Actually, I think I'll open a new PR with tests for all the adapters, since this PR is only for google |
DanRibbens
pushed a commit
that referenced
this pull request
Mar 30, 2026
…d comprehensive integration test suite with a vercel blob emulator (#16080) This PR: - Adds Vercel Blob Emulator `ghcr.io/payloadcms/vercel-blob-emulator:latest` from https://github.com/payloadcms/vercel-blob-emulator to our `docker-compose.yml` (same purpose as with `localstack`, `azure-storage` etc.) - Adds comprehensive integration test suite for the vercel blob adapter (before we did not have any), including client uploads. Pretty much copy of our tests for S3, just adapted for vercel SDK instead of AWS S3. - Updates the SDK (`@vercel/blob`) to `2.3.1` - Fixes an issue with `alwaysInsertFields` - previously we did not handle this property at all - the copied tests from S3 caught that. Similar to #15541 - Adds ability to override `baseUrl` with `STORAGE_VERCEL_BLOB_BASE_URL` env variable - required for the emulator so requests don't go to `*.blob.vercel-storage.com`. The emulator is good enough for local developing if you want to avoid locally either switching to local disk storage conditionally or using a vercel blob token.
milamer
pushed a commit
to milamer/payload
that referenced
this pull request
Apr 20, 2026
…d comprehensive integration test suite with a vercel blob emulator (payloadcms#16080) This PR: - Adds Vercel Blob Emulator `ghcr.io/payloadcms/vercel-blob-emulator:latest` from https://github.com/payloadcms/vercel-blob-emulator to our `docker-compose.yml` (same purpose as with `localstack`, `azure-storage` etc.) - Adds comprehensive integration test suite for the vercel blob adapter (before we did not have any), including client uploads. Pretty much copy of our tests for S3, just adapted for vercel SDK instead of AWS S3. - Updates the SDK (`@vercel/blob`) to `2.3.1` - Fixes an issue with `alwaysInsertFields` - previously we did not handle this property at all - the copied tests from S3 caught that. Similar to payloadcms#15541 - Adds ability to override `baseUrl` with `STORAGE_VERCEL_BLOB_BASE_URL` env variable - required for the emulator so requests don't go to `*.blob.vercel-storage.com`. The emulator is good enough for local developing if you want to avoid locally either switching to local disk storage conditionally or using a vercel blob token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13497
Previously, the
alwaysInsertFields: truefeature was not handled properly in this adapter.