fix(ui): adds delay to progress bar for fast networks#11157
Merged
Conversation
jacobsfletch
added a commit
that referenced
this pull request
Feb 17, 2025
On fast networks where page transitions are quick, such as local dev in most cases, the progress bar should not render. This leads to a constant flashing of the progress bar at the top of the screen and does not provide any value. The fix is to add a delay to the initial rendering of the progress bar, and only show if the transition takes longer than _n_ milliseconds. This value can be adjusted as needed, but right now is set to 150ms. Introduced in #9275.
Contributor
|
🚀 This is included in version v3.24.0 |
kendelljoseph
pushed a commit
that referenced
this pull request
Feb 21, 2025
On fast networks where page transitions are quick, such as local dev in most cases, the progress bar should not render. This leads to a constant flashing of the progress bar at the top of the screen and does not provide any value. The fix is to add a delay to the initial rendering of the progress bar, and only show if the transition takes longer than _n_ milliseconds. This value can be adjusted as needed, but right now is set to 150ms. Introduced in #9275.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On fast networks where page transitions are quick, such as local dev in most cases, the progress bar should not render. This leads to a constant flashing of the progress bar at the top of the screen and does not provide any value.
The fix is to add a delay to the initial rendering of the progress bar, and only show if the transition takes longer than n milliseconds. This value can be adjusted as needed, but right now is set to 150ms.
Introduced in #9275.