refactor(ui): deprecates Link props#11155
Merged
Merged
Conversation
jacobsfletch
added a commit
that referenced
this pull request
Feb 17, 2025
Deprecates all cases where `Link` could be sent as a prop. This was a relic from the past, where we attempted to make our UI library router-agnostic. This was a pipe dream and created more problems than it solved, for example the logout button was missing this prop, causing it to render an anchor tag and perform a hard navigation (caught in #9275). Does so in a non-breaking way, where these props are now optional and simply unused, as opposed to removing them outright.
Contributor
|
🚀 This is included in version v3.24.0 |
kendelljoseph
pushed a commit
that referenced
this pull request
Feb 21, 2025
Deprecates all cases where `Link` could be sent as a prop. This was a relic from the past, where we attempted to make our UI library router-agnostic. This was a pipe dream and created more problems than it solved, for example the logout button was missing this prop, causing it to render an anchor tag and perform a hard navigation (caught in #9275). Does so in a non-breaking way, where these props are now optional and simply unused, as opposed to removing them outright.
PatrikKozak
added a commit
that referenced
this pull request
Feb 27, 2025
This PR resolves an issue where the `href` for the Logout button in the admin panel included duplicate `basePath` values when `basePath` was set in `next.config.js`. The Logout button was recently updated to use `NextLink` (`next/link`), which automatically applies the `basePath` from the Next.js configuration. As a result, manually adding the `basePath` to the `href` is no longer necessary. Relevant PRs that modified this behavior originally: - #9275 - #11155
jacobsfletch
added a commit
that referenced
this pull request
Feb 27, 2025
When visiting a collection's list view, the nav item corresponding to that collection correctly appears in an active state, but is still rendered as an anchor tag. This makes it possible to reload the current page by simply clicking the link, which is a problem because this performs an unnecessary server roundtrip. This is especially apparent when search params exist in the current URL, as the href on the link does not. Unrelated: also cleans up leftover code that was missed in this PR: #11155
MrFriggo
added a commit
to TesseraktDevelopment/nakashi-shop
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates all cases where
Linkcould be sent as a prop. This was a relic from the past, where we attempted to make our UI library router-agnostic. This was a pipe dream and created more problems than it solved, for example the logout button was missing this prop, causing it to render an anchor tag and perform a hard navigation (caught in #9275).Does so in a non-breaking way, where these props are now optional and simply unused, as opposed to removing them outright.