Closed
Conversation
Co-authored-by: spacebear21 <git@spacebear.dev> Co-authored-by: nothingmuch <nothingmuch@woobling.org>
Contributor
Author
|
Another inconsistency to resolve |
nothingmuch
reviewed
Dec 6, 2024
Comment on lines
119
to
124
| origin: Url, | ||
| #[cfg(feature = "v2")] receiver_pubkey: Option<HpkePublicKey>, | ||
| #[cfg(feature = "v2")] receiver_pubkey: Option<HpkePublicKey>, // FIXME make Option<(pk, keys, exp)> | ||
| #[cfg(feature = "v2")] ohttp_keys: Option<OhttpKeys>, | ||
| #[cfg(feature = "v2")] expiry: Option<std::time::SystemTime>, | ||
| ) -> Self { |
benalleng
reviewed
Jan 9, 2025
Comment on lines
+140
to
143
| treat_missing_as_error: bool, // FIXME never used! remove! | ||
| ) -> Result<(), InternalPsbtInputError> { | ||
| match (&self.psbtin.non_witness_utxo, &self.psbtin.witness_utxo) { | ||
| (None, None) if treat_missing_as_error => |
Collaborator
There was a problem hiding this comment.
Do we want to always treat this as an error? I saw that every time we call this we always pass true
Contributor
Author
There was a problem hiding this comment.
I think we can just remove it from the signature and usage entirely
Collaborator
There was a problem hiding this comment.
ok, so the behavior if none would just be
(None, None) => {
Err(InternalPsbtInputError::PrevTxOut(PrevTxOutError::MissingUtxoInformation))
}
benalleng
added a commit
to benalleng/rust-payjoin
that referenced
this pull request
Jan 14, 2025
Many of these function signaures were audited in payjoin#405 and implemented here.
benalleng
added a commit
to benalleng/rust-payjoin
that referenced
this pull request
Jan 14, 2025
Many of these function signaures were audited in payjoin#405 and implemented here.
Merged
Collaborator
|
Closing this as it's being addressed in smaller PR chunks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.