Merged
Conversation
Should fix patriksimek#225 by tracking proxies and unsing the target of them in case of decontextify instead of them.
Owner
|
This is awesome. Thank you. |
patriksimek
added a commit
that referenced
this pull request
Sep 11, 2019
|
@patriksimek any ETA on when it gets included in a release? |
Owner
|
@XmiliaH Do you plan to do more PRs or should I release the current state? |
Collaborator
Author
|
Want to do a PR to fix writing to proto on external Objects. Also maybe traping deleteProperty on external Objects. Also want to rewrite lookupGetter and co to be more on the native side by looking also at the prtotype chain, but using the one from the sandbox instead. Should be out later this day. |
Owner
|
@faustbrian Released in 3.8.4. |
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #225 by tracking proxies and unsing the target of them in case of decontextify instead of them.