Skip to content

feat: Add support for agent profile install to global claude subagents directory#4

Closed
patricka3125 wants to merge 11 commits into
mainfrom
pl_dev_global
Closed

feat: Add support for agent profile install to global claude subagents directory#4
patricka3125 wants to merge 11 commits into
mainfrom
pl_dev_global

Conversation

@patricka3125

Copy link
Copy Markdown
Owner

No description provided.

…ents/ search)

- Remove CLAUDE_PROJECT_AGENTS_DIR constant from constants.py
- Remove working_directory param and project-level search from _load_claude_agent_profile()
- Remove _get_working_directory() helper method (no longer needed)
- Update _build_claude_command() to call global-only Claude agent lookup
- Update ProviderError message to reflect global-only scope
- Update all tests to match simplified global-only API
patricka3125 pushed a commit that referenced this pull request Apr 10, 2026
…wslabs#159) (awslabs#163)

* feat(kiro_cli): add full TUI mode support with --legacy-ui fallback (awslabs#159)

Remove hardcoded --legacy-ui from launch command and add TUI-native
status detection and message extraction. The provider now:

- Launches in TUI mode by default, falls back to --legacy-ui on timeout
- Detects COMPLETED via ▸ Credits: marker + idle prompt (TUI path)
- Extracts messages using separator (────) boundaries when no green arrows
- Retains full backward compatibility with legacy UI patterns

Also adds "aren't available" to e2e REFUSAL_KEYWORDS for Claude Code test fix.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* style: apply black formatting to kiro_cli provider and tests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(kiro_cli): address PR awslabs#163 review comments

- Raise separator minimum from 4 to 20 chars to avoid matching short
  markdown separators in agent output (jwalaQ comment #4)
- Remove redundant ANSI cleanup in _extract_tui_message — input is
  already ANSI-stripped by caller (jwalaQ comment #5)
- Improve timeout error message wording (jwalaQ comment #3)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat(kiro_cli): add TUI processing and permission detection patterns

- Add "Kiro is working" ghost text as positive PROCESSING signal,
  checked before idle prompt absence (jwalaQ comment #1)
- Add TUI permission pattern "Yes No Always Allow" alongside legacy
  [y/n/t] format, requires all three options to avoid false positives
  on bare "Yes"/"No" in agent output (jwalaQ comment #2)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(kiro_cli): update TUI idle pattern to match real kiro-cli v1.29+ output

Verified against real kiro-cli v1.29.1 TUI output via tmux capture-pane:
- Idle prompt is "Ask a question or describe a task" (capital A, no comma)
- Pattern now accepts both old (lowercase, comma) and new formats
- Updated fixtures to use real TUI output format
- Updated inline test strings to match v1.29+ output

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(kiro_cli): use forward-search for TUI separator to handle agent output separators (awslabs#159)

Changed _extract_tui_message() to find the first separator after the
previous turn's Credits line instead of the last separator before the
current Credits. This prevents false matches when agent output contains
box-drawing separator characters. Also updated docs for launch command.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(test): add 'Kiro is working' ghost text to TUI processing fixture (awslabs#159)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant