This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Moved DigestItem impl to impl_outer_log#932
Merged
Conversation
gavofyork
approved these changes
Oct 18, 2018
Contributor
Author
|
Seems like CI issue is not related to changes - it keeps failing even after revert. Also could confirm that I checked all tests before opening PR, after seeing CI failure, after reverting + after reverting revert && it always succeeded |
bkchr
approved these changes
Oct 18, 2018
…nto impl_outer_log_ex
…strate into impl_outer_log_ex
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* Move all deps to workspace toml * cargo fmt and codec 3.4, removing now unneeded 'full' feature * add wasm-tests to workspace and fix subxt inheritng * cargo fmt * wasm-test thing can't be in workspace so revert that * remove unwanted target dir from wasm-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #926
Brief overview:
impl DigestImpl for Logfrom runtime toimpl_outer_logmacro, so that it is implemented byconstruct_runtimemacroDigestItem::as_*methods to make sure when methods are adding,impl_outer_logmacro is also updated