Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fix lazy initialisation bug for parametizability#2046

Merged
gui1117 merged 3 commits intomasterfrom
gui-fix-spin
Mar 19, 2019
Merged

Fix lazy initialisation bug for parametizability#2046
gui1117 merged 3 commits intomasterfrom
gui-fix-spin

Conversation

@gui1117
Copy link
Contributor

@gui1117 gui1117 commented Mar 19, 2019

Lazy initialisation doesn't work on wasm for some (unknown yet) reason. This fix it by computing stuff at compile time.

Closes #2022

@gui1117 gui1117 requested a review from tomusdrw March 19, 2019 15:58
@gui1117 gui1117 added the A0-please_review Pull request needs code review. label Mar 19, 2019
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tomusdrw
Copy link
Contributor

I did some tests and it indeed seems to fix the issue.

@tomusdrw tomusdrw added A8-looksgood and removed A0-please_review Pull request needs code review. labels Mar 19, 2019
Copy link
Contributor

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, seems to fix the CantPay issue from #2022

@gui1117 gui1117 merged commit f996940 into master Mar 19, 2019
tomusdrw added a commit that referenced this pull request Mar 25, 2019
MTDK1 pushed a commit to bdevux/substrate that referenced this pull request Apr 12, 2019
remove lazy and compute prefix at compile time
@gui1117 gui1117 deleted the gui-fix-spin branch April 18, 2019 08:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvalidTransaction on latest master (after first tx success, latest master)

3 participants