This repository was archived by the owner on Nov 15, 2023. It is now read-only.
frame-benchmarking-cli: Remove native dispatch requirement#14474
Merged
frame-benchmarking-cli: Remove native dispatch requirement#14474
Conversation
No need for this, we can just use the `WasmExecutor` directly.
ggwpez
approved these changes
Jun 28, 2023
sam0x17
approved these changes
Jun 28, 2023
Contributor
sam0x17
left a comment
There was a problem hiding this comment.
LGTM, few minor doc tweaks
| /// execution engine as a preprocessing step and therefore don't yield a meaningful benchmark | ||
| /// result. However, in contrast to the instructions mentioned in 2. they can be spammed. We | ||
| /// price them with the same weight as the "default" instruction (i64.const): Block, Loop, Nop | ||
| /// 4. We price both i64.const and drop as InstructionWeights.i64const / 2. The reason for that is |
Contributor
There was a problem hiding this comment.
Suggested change
| /// 4. We price both i64.const and drop as InstructionWeights.i64const / 2. The reason for that is | |
| /// 4. We price both `i64.const` and drop as `InstructionWeights.i64.const` / 2. The reason for that is |
| /// 3. The following instructions cannot be benchmarked because they are removed by any real world | ||
| /// execution engine as a preprocessing step and therefore don't yield a meaningful benchmark | ||
| /// result. However, in contrast to the instructions mentioned in 2. they can be spammed. We | ||
| /// price them with the same weight as the "default" instruction (i64.const): Block, Loop, Nop |
Contributor
There was a problem hiding this comment.
Suggested change
| /// price them with the same weight as the "default" instruction (i64.const): Block, Loop, Nop | |
| /// price them with the same weight as the "default" instruction (`i64.const`): Block, Loop, Nop |
skunert
approved these changes
Jun 28, 2023
davxy
approved these changes
Jun 29, 2023
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…h#14474) * frame-benchmarking-cli: Remove native dispatch requirement No need for this, we can just use the `WasmExecutor` directly. * Fixes * Pass benchmarking host functions * Ensure we can pass custom host functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need for this, we can just use the
WasmExecutordirectly.Changes
Removes the requirement to pass the
ExecDispatchgeneric parameter and instead to pass the host functions directly. If you don't want to add any extra host functions, you can just pass()toPalletCmd::run.polkadot companion: paritytech/polkadot#7434
cumulus companion: paritytech/cumulus#2792