Adds ability to prepare/initialize before running `set_code` benchmark by bkontur · Pull Request #14435 · paritytech/substrate

bkontur · 2023-06-21T18:56:15Z

See detailed description here: paritytech/cumulus#2765

Cumulus companion: paritytech/cumulus#2766

bkontur · 2023-06-21T19:44:22Z

bot bench $ pallet dev frame-system
bot bench $ pallet dev frame-system-benchmarking

command-bot · 2023-06-21T19:44:27Z

@bkontur https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3046481 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev frame-system. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-6f403e28-2ed1-49c5-a5de-c410e705e17d to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-06-21T19:44:31Z

@bkontur https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3046482 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev frame-system-benchmarking. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-4dabaa89-dca6-43ca-8d4a-04b9dcec557e to cancel this command or bot cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2023-06-21T20:11:30Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev frame-system has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3046481 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3046481/artifacts/download.

command-bot · 2023-06-21T20:37:50Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev frame-system-benchmarking has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3046482 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3046482/artifacts/download.

…nto bko-set_code-benchmark-helper

bkontur · 2023-06-22T09:07:06Z

bot bench $ pallet dev frame-system

command-bot · 2023-06-22T09:07:12Z

@bkontur https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3049124 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev frame-system. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-13610fb0-3041-47a3-a8d8-a0603647936f to cancel this command or bot cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2023-06-22T09:34:36Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev frame-system has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3049124 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3049124/artifacts/download.

bkchr · 2023-06-22T09:56:37Z

frame/system/benchmarking/src/lib.rs

+	/// Adds ability to the Runtime to test against their sample code.
+	/// Default is `../res/kitchensink_runtime.compact.compressed.wasm`.
+	fn set_code_data() -> Vec<u8> {
+		include_bytes!("../res/kitchensink_runtime.compact.compressed.wasm").to_vec()
+	}


This is a very very good idea! :)

…onFunctionStored instead of CodeUpdated)

…nto bko-set_code-benchmark-helper

bkontur · 2023-06-22T10:32:58Z

bot bench $ pallet dev frame-system

command-bot · 2023-06-22T10:33:03Z

@bkontur https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3050145 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev frame-system. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-d64ed87d-7cc8-4e72-86b9-7cfbcf1d7cad to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-06-22T11:00:28Z

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev frame-system has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3050145 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3050145/artifacts/download.

ggwpez · 2023-06-22T11:57:30Z

bot bench-vm $ pallet dev frame-system

command-bot · 2023-06-22T11:57:35Z

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3051678 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" pallet dev frame-system. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-e9831320-64b0-4f0e-a0c9-de4922bb4637 to cancel this command or bot cancel to cancel all commands in this pull request.

ggwpez

Need to wait for the new bench cmd to finish, then its good to go 🚀

command-bot · 2023-06-22T12:33:55Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" pallet dev frame-system has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3051678 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3051678/artifacts/download.

bkontur · 2023-06-23T12:02:04Z

bot merge

paritytech#14435) * Adds ability to prepare/initialize before running `set_code` benchmark * Fix * ".git/.scripts/commands/bench/bench.sh" pallet dev frame-system * Replaced BenchmarkHelper with function * Fix * Introduced `set_code_data` for benchmark with default value * ".git/.scripts/commands/bench/bench.sh" pallet dev frame-system * (Hope) Final adjustment (because system parachains generates ValidationFunctionStored instead of CodeUpdated) * ".git/.scripts/commands/bench/bench.sh" pallet dev frame-system * ".git/.scripts/commands/bench-vm/bench-vm.sh" pallet dev frame-system --------- Co-authored-by: command-bot <>

Adds ability to prepare/initialize before running set_code benchmark

97c8819

bkontur added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 21, 2023

Fix

5ebe07a

command-bot added 2 commits June 21, 2023 19:44

Merge branch 'master' of https://github.com/paritytech/substrate into…

43b77d7

… HEAD

".git/.scripts/commands/bench/bench.sh" pallet dev frame-system

ef05cbe

This was referenced Jun 21, 2023

Companion for substrate#14435 (BenchmarkHelper for frame-system) paritytech/polkadot#7413

Closed

Companion for substrate#14435 (BenchmarkHelper for frame-system) paritytech/cumulus#2766

Merged

bkontur added 3 commits June 22, 2023 00:05

Replaced BenchmarkHelper with function

68b4fc9

Merge remote-tracking branch 'origin/bko-set_code-benchmark-helper' i…

06825ac

…nto bko-set_code-benchmark-helper

Fix

f344330

bkchr approved these changes Jun 21, 2023

View reviewed changes

bkontur added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Jun 22, 2023

Introduced set_code_data for benchmark with default value

499d3f0

bkontur marked this pull request as ready for review June 22, 2023 09:07

bkontur requested review from a team June 22, 2023 09:07

Merge branch 'master' of https://github.com/paritytech/substrate into…

a9237e2

… HEAD

acatangiu approved these changes Jun 22, 2023

View reviewed changes

".git/.scripts/commands/bench/bench.sh" pallet dev frame-system

9845114

bkchr reviewed Jun 22, 2023

View reviewed changes

(Hope) Final adjustment (because system parachains generates Validati…

2434f9b

…onFunctionStored instead of CodeUpdated)

Merge remote-tracking branch 'origin/bko-set_code-benchmark-helper' i…

4404602

…nto bko-set_code-benchmark-helper

".git/.scripts/commands/bench/bench.sh" pallet dev frame-system

8b35862

bkontur mentioned this pull request Jun 22, 2023

Fix benchmarks set_code for frame_system pallet for all SP runtimes paritytech/cumulus#2765

Closed

ggwpez approved these changes Jun 22, 2023

View reviewed changes

".git/.scripts/commands/bench-vm/bench-vm.sh" pallet dev frame-system

928cde4

paritytech-processbot bot merged commit dc3fb3d into master Jun 23, 2023

paritytech-processbot bot deleted the bko-set_code-benchmark-helper branch June 23, 2023 12:02

bkontur mentioned this pull request Jul 24, 2023

[benchmarks] Update weights for collectives paritytech/cumulus#2916

Merged

1 task

Conversation

bkontur commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkontur commented Jun 21, 2023

Uh oh!

command-bot bot commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jun 21, 2023

Uh oh!

command-bot bot commented Jun 21, 2023

Uh oh!

bkontur commented Jun 22, 2023

Uh oh!

command-bot bot commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jun 22, 2023

Uh oh!

bkchr Jun 22, 2023

Choose a reason for hiding this comment

Uh oh!

bkontur commented Jun 22, 2023

Uh oh!

command-bot bot commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jun 22, 2023

Uh oh!

ggwpez commented Jun 22, 2023

Uh oh!

command-bot bot commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ggwpez left a comment

Choose a reason for hiding this comment

Uh oh!

command-bot bot commented Jun 22, 2023

Uh oh!

bkontur commented Jun 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bkontur commented Jun 21, 2023 •

edited

Loading

command-bot bot commented Jun 21, 2023 •

edited

Loading

command-bot bot commented Jun 21, 2023 •

edited

Loading

command-bot bot commented Jun 22, 2023 •

edited

Loading

command-bot bot commented Jun 22, 2023 •

edited

Loading

command-bot bot commented Jun 22, 2023 •

edited

Loading