Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Restructure macro-related exports into private mods for frame#14375

Merged
paritytech-processbot[bot] merged 4 commits intoparitytech:masterfrom
gui1117:gui-macro-reexport-refactor
Jun 14, 2023
Merged

Restructure macro-related exports into private mods for frame#14375
paritytech-processbot[bot] merged 4 commits intoparitytech:masterfrom
gui1117:gui-macro-reexport-refactor

Conversation

@gui1117
Copy link
Contributor

@gui1117 gui1117 commented Jun 14, 2023 •
edited
Loading

related issue: paritytech/polkadot-sdk#172
cumulus companion: paritytech/cumulus#2733

There is still some in the primitives but we can do in another PR
And there is some in frame/support/src/lib.rs but I think some people are using them like a frame umbrella crate (#14137). So it is probably better to wait for frame crate to give them a smooth transition.

breaking change

  • frame::support::inherent::BlockT is removed and should be imported from sp_runtime::traits::Block.
  • frame::support::inherent::Extrinsic is removed and should be imported from sp-runtime::traits::Extrinsic
  • some other minor type re-export are removed and should be imported from their respective origins.

@gui1117 gui1117 requested review from a team June 14, 2023 08:45
gui1117
gui1117 commented Jun 14, 2023
View reviewed changes
bkchr
bkchr approved these changes Jun 14, 2023
View reviewed changes
@bkchr bkchr added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. labels Jun 14, 2023
@gui1117 @bkchr
Update frame/election-provider-support/solution-type/src/lib.rs
7fc6d12 
Co-authored-by: Bastian Köcher <git@kchr.de>
@ggwpez
Copy link
Member

ggwpez commented Jun 14, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Jun 14, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2988827 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-8bc9cb28-a6cb-4c43-bd21-d7372df1dbde to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 14, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2988827 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2988827/artifacts/download.

ggwpez
ggwpez approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Cumulus is failing… maybe you can fix it prior to this, so it wont need a companion.

@gui1117 gui1117 mentioned this pull request Jun 14, 2023
Merged
@gui1117
Copy link
Contributor Author

gui1117 commented Jun 14, 2023

cumulus companion mergeable ahead here paritytech/cumulus#2733
tests are running locally it looks good so far

@ggwpez
Copy link
Member

ggwpez commented Jun 14, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 2cc1667 into paritytech:master Jun 14, 2023
@gui1117 gui1117 deleted the gui-macro-reexport-refactor branch June 14, 2023 13:04
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@gui1117 @bkchr @nathanwhit
Restructure macro-related exports into private mods for frame (parity…
993d034 
…tech#14375)

* minor refactor

* Update frame/election-provider-support/src/lib.rs

* Update frame/election-provider-support/solution-type/src/lib.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: command-bot <>
@ggwpez ggwpez mentioned this pull request Aug 24, 2023
Open
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gui1117 @ggwpez @sam0x17 @bkchr