This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Drain all the pending messages in the channel when TracingUnboundedReceiver is dropped#13917
Merged
bkchr merged 1 commit intoparitytech:masterfrom Apr 14, 2023
Merged
Conversation
…ceiver is dropped Signed-off-by: linning <linningde25@gmail.com>
bkchr
approved these changes
Apr 14, 2023
Member
|
ty! |
dmitry-markin
approved these changes
Apr 14, 2023
Contributor
dmitry-markin
left a comment
There was a problem hiding this comment.
Looks good, thanks!
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…ceiver is dropped (paritytech#13917) Signed-off-by: linning <linningde25@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13849
tracing_unboundedusesasync_channelinternally, in which, the pending messages of the channel will not be dropped even if all the receivers have been dropped and these messages can never be accessed.This may cause blocking issues when using
tracing_unboundedto sendSender<T>and there is quite a lot of such usage within substrate as #13849 mentioned.This PR fixes the issue by manually draining all the pending messages in the channel when
TracingUnboundedReceiveris dropped and a test is added to cover the abovementioned case.cc @bkchr