This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Collective pallet: max proposal weight#13771
Merged
paritytech-processbot[bot] merged 4 commits intomasterfrom Apr 19, 2023
Merged
Collective pallet: max proposal weight#13771paritytech-processbot[bot] merged 4 commits intomasterfrom
paritytech-processbot[bot] merged 4 commits intomasterfrom
Conversation
This was referenced Mar 30, 2023
Contributor
Author
|
bot rebase |
…-max-proposal-weight
|
Rebased |
bkchr
approved these changes
Mar 31, 2023
Member
bkchr
left a comment
There was a problem hiding this comment.
Personally I would probably favor a disapprove_proposal that can be initiated by a simple majority of collective members to cancel a call.
Comment on lines
+717
to
+721
| let proposal_weight = proposal.get_dispatch_info().weight; | ||
| ensure!( | ||
| proposal_weight.all_lte(T::MaxProposalWeight::get()), | ||
| Error::<T, I>::WrongProposalWeight | ||
| ); |
Member
There was a problem hiding this comment.
The proposal weight is already added to the weight of propose if threshold < 2. So, we would not even add this tx to a block when the weight is too big. TLDR: This should not be required.
Member
There was a problem hiding this comment.
But yeah, to have the properties as do_propose_proposed it makes sense.
ggwpez
approved these changes
Mar 31, 2023
Contributor
Author
|
bot merge |
|
Error: Github API says paritytech/cumulus#2410 is not mergeable |
Contributor
Author
|
bot rebase |
…-max-proposal-weight
|
Rebased |
Contributor
Author
|
bot merge |
|
Error: Github API says paritytech/polkadot#6983 is not mergeable |
Member
|
bot merge |
15 tasks
aurexav
added a commit
to darwinia-network/darwinia
that referenced
this pull request
Jul 11, 2023
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* collective: max proposal weight * fix test --------- Co-authored-by: parity-processbot <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing a limit for the weight of the proposed call.
polkadot companion: paritytech/polkadot#6983
cumulus companion: paritytech/cumulus#2410