Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Alliance pallet: split force_set_members call#12179

Merged
paritytech-processbot[bot] merged 5 commits intomasterfrom
muharem-split-force-set-members-call
Sep 5, 2022
Merged

Alliance pallet: split force_set_members call#12179
paritytech-processbot[bot] merged 5 commits intomasterfrom
muharem-split-force-set-members-call

Conversation

@muharem
Copy link
Contributor

@muharem muharem commented Sep 3, 2022 •
edited
Loading

Splitting force_set_members call for simplification.

  • split force_set_members into init_members and disband;
  • remove proposals.veto from disband call. the ability to veto active proposals should be provided by runtime and batched if necessary;
  • use actual member sets count for the init_members call weight calculation instead T::Max*.

Cumulus companion: paritytech/cumulus#1593

@muharem muharem added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Sep 3, 2022
@muharem muharem added the C1-low PR touches the given topic and has a low impact on builders. label Sep 3, 2022
@muharem muharem mentioned this pull request Sep 3, 2022
Merged
joepetrowski
joepetrowski approved these changes Sep 5, 2022
View reviewed changes
gilescope
gilescope approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add_unscrupulous_items looks a better weight now.

@muharem
Copy link
Contributor Author

muharem commented Sep 5, 2022

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Sep 5, 2022

Error: "Check reviews" status is not passing for paritytech/cumulus#1593

@muharem
Copy link
Contributor Author

muharem commented Sep 5, 2022

/cmd queue -c bench-bot $ pallet dev pallet_alliance

@command-bot
Copy link

command-bot bot commented Sep 5, 2022 •
edited
Loading

@muharem https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1809798 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 47-27c34065-57ef-455e-bd74-615e2a74d6da to cancel this command or /cmd cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Sep 5, 2022

@muharem Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1809798 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1809798/artifacts/download.

@muharem
Copy link
Contributor Author

muharem commented Sep 5, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 5f18a8b into master Sep 5, 2022
@paritytech-processbot paritytech-processbot bot deleted the muharem-split-force-set-members-call branch September 5, 2022 15:08
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@muharem @ark0f
Alliance pallet: split force_set_members call (paritytech#12179)
e21ed32 
* Alliance pallet: split force_set_members call

* use counts for event

* ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@gilescope gilescope gilescope approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@muharem @gilescope @joepetrowski