Alliance pallet: add force_set_members instead of init_members function by muharem · Pull Request #11997 · paritytech/substrate

muharem · 2022-08-09T10:52:07Z

Fixes #11928

Root call init_members which is mean to initialize the alliance can be called only once. If an initial call had a mistake or the alliance lost the trust, there is no way to reset the alliance.

In the PR we changing the name and behaviour of the init_members function. Instead force_set_members function lets perform a root call on already initialized alliance, which will reset it and initialize new.

Cumulus companion: paritytech/cumulus#1551

joepetrowski

Looks good except a few questions and doc suggestions.

frame/alliance/src/lib.rs

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

This reverts commit b654d68.

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

joepetrowski

Would consider changing the event MembersInitialized to MembershipSet, but otherwise looks good.

frame/alliance/src/lib.rs

frame/alliance/src/types.rs

frame/alliance/src/lib.rs

frame/alliance/src/types.rs

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

muharem · 2022-08-16T09:18:17Z

/cmd queue -c bench-bot $ pallet dev pallet_alliance

command-bot · 2022-08-16T09:18:22Z

@muharem https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1748367 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 4-33dfdab3-6470-40bc-a94c-e87f52cc9b75 to cancel this command or /cmd cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2022-08-16T09:39:52Z

@muharem Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1748367 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1748367/artifacts/download.

…ce-set-members

muharem · 2022-08-31T16:59:56Z

/cmd queue -c bench-bot $ pallet dev pallet_alliance

command-bot · 2022-08-31T17:00:00Z

@muharem https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1796091 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 42-4ad37e86-dd93-4c11-ad30-460c8195be8e to cancel this command or /cmd cancel to cancel all commands in this pull request.

command-bot · 2022-08-31T17:00:21Z

@muharem Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1796091 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1796091/artifacts/download.

…ce-set-members

muharem · 2022-08-31T20:58:54Z

frame/alliance/src/lib.rs

+			if founders.is_empty() {
+				ensure!(fellows.is_empty() && allies.is_empty(), Error::<T, I>::FoundersMissing);
+				// new members set not provided.
+				return Ok(())


I will return an actual weight here, and below. It can vary a lot from the assumed one.

joepetrowski

Just a few nits

frame/alliance/src/lib.rs

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

muharem · 2022-09-01T08:42:12Z

/cmd queue -c bench-bot $ pallet dev pallet_alliance

command-bot · 2022-09-01T08:42:17Z

@muharem https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1797264 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 43-51aa43f5-b273-492f-8274-dbf450ee286c to cancel this command or /cmd cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2022-09-01T09:06:16Z

@muharem Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_alliance has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1797264 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1797264/artifacts/download.

gilescope

LGTM. Could break out disband alliance into it's own dispatchable function as a later PR but not essential.

muharem · 2022-09-01T10:10:22Z

bot merge

paritytech-processbot · 2022-09-01T10:10:31Z

Error: Github API says paritytech/cumulus#1551 is not mergeable

muharem · 2022-09-01T10:31:24Z

bot merge

…on (paritytech#11997) * Alliance pallet: add force_set_members instead of init_members function * benchmark with witness data * remove invalid limit for clear * Apply suggestions from code review Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Revert "remove invalid limit for clear" This reverts commit b654d68. * compile constructor only for test * Update comments for force_set_members Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance * benchmark - founders count range * Revert "benchmark - founders count range" This reverts commit 744178f. * witness members count instead votable members count * update the doc * use decode_len for witness data checks * change witness data member count to voting member count; update clear limits * ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance * merge master * fixes after merge master * revert to cb3e63 * disband alliance and return deposits * revert debug changes * weights * update docs * update test comments * Apply Joe suggestions from code review Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * rename event from AllianceDisband to AllianceDisbanded * ".git/.scripts/bench-bot.sh" pallet dev pallet_alliance Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: command-bot <>

Alliance pallet: add force_set_members instead of init_members function

2007c1f

joepetrowski reviewed Aug 10, 2022

View reviewed changes

muharem and others added 6 commits August 12, 2022 12:43

benchmark with witness data

a405dfc

remove invalid limit for clear

b654d68

Apply suggestions from code review

855bb3d

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Revert "remove invalid limit for clear"

7ad0f97

This reverts commit b654d68.

compile constructor only for test

8b071c4

Update comments for force_set_members

fb4c22c

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

muharem requested a review from joepetrowski August 12, 2022 12:10

joepetrowski approved these changes Aug 12, 2022

View reviewed changes

Apply suggestions from code review

a40904e

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

command-bot added 2 commits August 16, 2022 09:18

Merge branch 'master' of https://github.com/paritytech/substrate into…

8a254b4

… HEAD

".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

d202ae2

muharem requested review from bkchr, gilescope, kianenigma and shawntabrizi August 16, 2022 10:05

benchmark - founders count range

744178f

muharem requested a review from bkontur August 16, 2022 10:20

muharem added the D2-breaksapi label Aug 16, 2022

muharem requested a review from andresilva as a code owner August 29, 2022 20:12

muharem added 2 commits August 29, 2022 22:23

revert to cb3e63

f9312c5

Merge remote-tracking branch 'origin/master' into pallet-alliance-for…

ccc35ed

…ce-set-members

muharem removed the request for review from andresilva August 29, 2022 20:48

muharem added 2 commits August 31, 2022 18:45

disband alliance and return deposits

f7828c2

revert debug changes

9531b8a

muharem added 4 commits August 31, 2022 19:27

Merge remote-tracking branch 'origin/master' into pallet-alliance-for…

5136902

…ce-set-members

weights

973483d

update docs

5cfb043

update test comments

145d14e

muharem commented Aug 31, 2022

View reviewed changes

joepetrowski reviewed Sep 1, 2022

View reviewed changes

frame/alliance/src/lib.rs Outdated Show resolved Hide resolved

frame/alliance/src/lib.rs Outdated Show resolved Hide resolved

frame/alliance/src/lib.rs Outdated Show resolved Hide resolved

frame/alliance/src/lib.rs Outdated Show resolved Hide resolved

muharem and others added 2 commits September 1, 2022 10:30

Apply Joe suggestions from code review

183ee71

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

rename event from AllianceDisband to AllianceDisbanded

91b5891

command-bot added 2 commits September 1, 2022 08:42

Merge branch 'master' of https://github.com/paritytech/substrate into…

e730aa2

… HEAD

".git/.scripts/bench-bot.sh" pallet dev pallet_alliance

7ba3056

gilescope approved these changes Sep 1, 2022

View reviewed changes

paritytech-processbot bot merged commit 4f8207d into master Sep 1, 2022

paritytech-processbot bot deleted the pallet-alliance-force-set-members branch September 1, 2022 10:31

librelois mentioned this pull request Sep 15, 2022

Update substrate/polkadot/cumulus from v0.9.26 to v0.9.29 moonbeam-foundation/moonbeam#1814

Closed

2 tasks

Conversation

muharem commented Aug 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joepetrowski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joepetrowski left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

muharem commented Aug 16, 2022

Uh oh!

command-bot bot commented Aug 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Aug 16, 2022

Uh oh!

muharem commented Aug 31, 2022

Uh oh!

command-bot bot commented Aug 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Aug 31, 2022

Uh oh!

muharem Aug 31, 2022

Choose a reason for hiding this comment

Uh oh!

joepetrowski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

muharem commented Sep 1, 2022

Uh oh!

command-bot bot commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Sep 1, 2022

Uh oh!

gilescope left a comment

Choose a reason for hiding this comment

Uh oh!

muharem commented Sep 1, 2022

Uh oh!

paritytech-processbot bot commented Sep 1, 2022

Uh oh!

muharem commented Sep 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

muharem commented Aug 9, 2022 •

edited

Loading

joepetrowski left a comment •

edited

Loading

command-bot bot commented Aug 16, 2022 •

edited

Loading

command-bot bot commented Aug 31, 2022 •

edited

Loading

command-bot bot commented Sep 1, 2022 •

edited

Loading