This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add tool to help identify faulty Cargo features selections#11715
Closed
koenw wants to merge 1 commit intoparitytech:masterfrom
Closed
Add tool to help identify faulty Cargo features selections#11715koenw wants to merge 1 commit intoparitytech:masterfrom
koenw wants to merge 1 commit intoparitytech:masterfrom
Conversation
As requested in [Opstooling paritytech#55](https://github.com/paritytech/opstooling/issues/55), add a tool to print dependency crates that have `default-features = false` but are not part of the `std` feature. Usage: `cargo run -p deps-check` to recursively check all `Cargo.toml`s below the current directory or `cargo run -p deps-check -- /path/to/Cargo.toml` to check a specific `Cargo.toml`.
Member
|
@shawntabrizi already has written such a tool or? |
Member
Member
|
I think a rust version of this tool would be better. Happy to contribute to it. I thought it would make sense for something like this to ultimately live in Diener? |
Contributor
Author
|
Since everyone seems to agree this functionality should be part of Diener I'm closing this PR. I opened a new PR to Diener instead: paritytech/diener#19. |
Contributor
|
This had already been implemented in subalfred. And it was used by Darwinia CI for over a year. It also handles the new cargo feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in Opstooling #55, add a tool to print dependency crates that have
default-features = falsebut are not part of thestdfeature.Usage:
cargo run -p deps-checkto recursively check allCargo.tomls below the current directory orcargo run -p deps-check -- /path/to/Cargo.tomlto check a specificCargo.toml.