Closed
Conversation
The `check-features` subcommand checks all `Cargo.toml` files in a given folder for dependencies that have `default-features = false` but are not part of the `std` feature.
Member
|
Is there a reason for parsing and then whether or not it is enabled in the features: So it even tells you if the |
Author
|
I guess that would work too, but I'm not working on this anymore so I haven't really thought about it. |
Contributor
|
@koenw do you plan on keeping your work on this PR or shall we close it ? |
Author
|
@chevdor I do not plan to work on this PR, feel free to close. |
Contributor
|
I still like the idea, we can reopen this later if bandwidth allows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
check-featuressubcommand checks allCargo.tomlfiles in a given folder for dependencies that havedefault-features = falsebut are not part of thestdfeature.This functionality was originally requested in Opstooling #55 and further discussed in Substrate #11715.
In order to facilitate these changes I've also updated the
cargo_editdependency.